Refactor to simplify netfx retargeting #2024
Conversation
There was a problem hiding this comment.
Why not adding a build variable (like NhAppTargetFrameworks, so maybe NhNetFxTarget) instead, and using it everywhere we currently hard-code net461? NHibernate.Tool.HbmXsd\NHibernate.Tool.HbmXsd.csproj could also benefit of it.
default.build should also use a similar solution, since it also needs some updating at many places if we change the NetFx target framework.
(There are many other net461 occurrences in the sources, but those which should change cannot be handled similarly.)
| <PropertyGroup Condition="'$(TargetFramework)' == 'net461'"> | ||
| <DefineConstants>NET461,$(DefineConstants)</DefineConstants> | ||
| <PropertyGroup Condition="$(TargetFramework.StartsWith('net4'))"> | ||
| <DefineConstants>NETFX,$(DefineConstants)</DefineConstants> |
In theory NHibernate can build multiple netfx targets so I think we don't need to introduce separate single netfx target property. And I would like to keep scope of this PR to NHibenate solution |
I was checking some stuff under .NET 4.7 and have had some struggle to make it compile. So let's simplify it a bit..